-
Notifications
You must be signed in to change notification settings - Fork 27
feat: update 'create' cmd section to 'AI Agent app' #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 64.84% 64.86% +0.02%
==========================================
Files 212 212
Lines 17538 17538
==========================================
+ Hits 11372 11376 +4
+ Misses 5096 5094 -2
+ Partials 1070 1068 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks LGTM and thanks for keeping us withe the latest 👾 ✨
It's interesting to find that changes to available template strings were all that's needed for this change, but testing still finds the right templates for me!
I do wonder if we should follow up with renaming templates from "bolt-js-assistant-template" to "bolt-js-agent-template" but we can save this discussion for later of course 🚢
cmd/project/create_template.go
Outdated
| { | ||
| Title: fmt.Sprintf("Automation app %s", style.Secondary("Custom steps and workflows")), | ||
| Repository: "slack-cli#automation-apps", | ||
| Title: fmt.Sprintf("Agentic AI app %s %s", style.Secondary("Slack agents and assistants"), style.Emoji("sparkles")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Title: fmt.Sprintf("Agentic AI app %s %s", style.Secondary("Slack agents and assistants"), style.Emoji("sparkles")), | |
| Title: fmt.Sprintf("Agentic AI app %s", style.Secondary("Slack agents and assistants")), |
suggestion(non-blocking): This highlights interesting features but I wonder if moving this to be the second option suffices? The emoji logic might otherwise output strange characters for Windows machines at this time...
cmd/project/create_template.go
Outdated
| { | ||
| Title: fmt.Sprintf("Automation app %s", style.Secondary("Custom steps and workflows")), | ||
| Repository: "slack-cli#automation-apps", | ||
| Title: fmt.Sprintf("Agentic AI app %s %s", style.Secondary("Slack agents and assistants"), style.Emoji("sparkles")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Title: fmt.Sprintf("Agentic AI app %s %s", style.Secondary("Slack agents and assistants"), style.Emoji("sparkles")), | |
| Title: fmt.Sprintf("AI Agent apps %s %s", style.Secondary("Slack agents and assistants"), style.Emoji("sparkles")), |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Eden Zimbelman <[email protected]>
@zimeg We do want to update the agent template URLs, but not yet. I think we will be reverting the assistant template back to it's original state and introducing a new, dedicated AI Agent template in the coming weeks. So when that's complete, we can update the CLI URLs to use the new AI Agent template URL. |
Changelog
Summary
This pull request updates the
slack createcommand's section from "AI app" to "Agentic AI app" to align with Slack's AI branding and the industry's general direction.Preview
Requirements